-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for MemberDefaultLockoutTimeInMinutes lockout time #16832
Fix for MemberDefaultLockoutTimeInMinutes lockout time #16832
Conversation
Hi there @KudAndrii, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
JasonElkin as you asked, the new pr is open |
Thanks @KudAndrii, we'll get this reviewed and get back to you soon. |
Thanks @KudAndrii for fixing this, and congratulations on your first PR to Umbraco! 🙌🎉 If you have a profile on our.umbraco.com, then let us know your username and we'll give you a shiny new C-Trib badge. |
Andrii Kud, just created, didn't know that I can receive a badge =) |
Thanks @KudAndrii and congrats on your contributor badge! https://our.umbraco.com/members/KudAndrii 🏅 |
Issue:
#15712
Description:
UserDefaultLockoutTimeInMinutes was wrongly used instead of MemberDefaultLockoutTimeInMinutes to configure lockout time.
Testing:
enter wrong password needed amount of times to be locked out, and you will be locked out on UserDefaultLockoutTimeInMinutes amount of minutes without this fix.