Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MemberDefaultLockoutTimeInMinutes lockout time #16832

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

KudAndrii
Copy link

Issue:
#15712

Description:
UserDefaultLockoutTimeInMinutes was wrongly used instead of MemberDefaultLockoutTimeInMinutes to configure lockout time.

Testing:
enter wrong password needed amount of times to be locked out, and you will be locked out on UserDefaultLockoutTimeInMinutes amount of minutes without this fix.

Copy link

github-actions bot commented Jul 27, 2024

Hi there @KudAndrii, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@KudAndrii
Copy link
Author

JasonElkin as you asked, the new pr is open
your_comment

@KudAndrii KudAndrii mentioned this pull request Jul 27, 2024
@JasonElkin JasonElkin self-assigned this Jul 29, 2024
@JasonElkin
Copy link
Contributor

Thanks @KudAndrii, we'll get this reviewed and get back to you soon.

@emmagarland emmagarland changed the title Issue #15712 Fix for MemberDefaultLockoutTimeInMinutes lockout timein v13 Aug 9, 2024
@emmagarland emmagarland changed the title Fix for MemberDefaultLockoutTimeInMinutes lockout timein v13 Fix for MemberDefaultLockoutTimeInMinutes lockout time Aug 9, 2024
@JasonElkin JasonElkin merged commit 09f16c3 into umbraco:v13/contrib Aug 15, 2024
6 of 8 checks passed
@JasonElkin
Copy link
Contributor

Thanks @KudAndrii for fixing this, and congratulations on your first PR to Umbraco! 🙌🎉

If you have a profile on our.umbraco.com, then let us know your username and we'll give you a shiny new C-Trib badge.

@KudAndrii
Copy link
Author

Thanks @KudAndrii for fixing this, and congratulations on your first PR to Umbraco! 🙌🎉

If you have a profile on our.umbraco.com, then let us know your username and we'll give you a shiny new C-Trib badge.

Andrii Kud, just created, didn't know that I can receive a badge =)

@nul800sebastiaan
Copy link
Member

Thanks @KudAndrii and congrats on your contributor badge! https://our.umbraco.com/members/KudAndrii 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants