Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors due to merge of PR #16991 #17176

Merged

Ignore warnings about using obsolete members in Umbraco.Tests.UnitTes…

77b802d
Select commit
Loading
Failed to load commit list.
Merged

Fix build errors due to merge of PR #16991 #17176

Ignore warnings about using obsolete members in Umbraco.Tests.UnitTes…
77b802d
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib) succeeded Oct 2, 2024 in 1m 51s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (7.22 -> 7.22)

  • Improving Code Health: 6 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Lines of Code in a Single File BlockListElementLevelVariationTests.Publishing.cs
  • Large Method BlockListElementLevelVariationTests.Publishing.cs: Can_Publish_With_Blocks_Removed
  • Large Method BlockListElementLevelVariationTests.Publishing.cs: Can_Publish_With_Blocks_In_One_Language
  • Large Method BlockListElementLevelVariationTests.Publishing.cs: Can_Expose_Both_Variant_And_Invariant_Blocks
  • Large Method BlockListElementLevelVariationTests.Publishing.cs: Can_Publish_With_Blocks_Exposed
  • Primitive Obsession ContentNavigationServiceBaseTests.cs

Annotations

Check notice on line 1 in tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/PropertyEditors/BlockListElementLevelVariationTests.Publishing.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

✅ Getting better: Lines of Code in a Single File

The lines of code decreases from 1138 to 1129, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 876 in tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/PropertyEditors/BlockListElementLevelVariationTests.Publishing.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

✅ Getting better: Large Method

Can_Publish_With_Blocks_Removed decreases from 106 to 105 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1045 in tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/PropertyEditors/BlockListElementLevelVariationTests.Publishing.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

✅ Getting better: Large Method

Can_Publish_With_Blocks_In_One_Language decreases from 87 to 85 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1328 in tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/PropertyEditors/BlockListElementLevelVariationTests.Publishing.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

✅ Getting better: Large Method

Can_Expose_Both_Variant_And_Invariant_Blocks decreases from 75 to 73 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1127 in tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/PropertyEditors/BlockListElementLevelVariationTests.Publishing.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

✅ Getting better: Large Method

Can_Publish_With_Blocks_Exposed decreases from 71 to 70 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1 in tests/Umbraco.Tests.UnitTests/Umbraco.Core/Services/ContentNavigationServiceBaseTests.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

✅ Getting better: Primitive Obsession

The ratio of primitive types in function arguments decreases from 93.94% to 93.55%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.