Update terminology in ListView acceptance tests for v14+. #17265
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
This PR partially addresses #17230 (in conjunction with umbraco/Umbraco.CMS.Backoffice#2452)
Description
This PR is an update to the acceptance tests for the Collection Workspace View (List View). It doesn't make any changes to the functionality of the tests but rather just to the test names and, in one instance, a string provided when arranging a test. To test this PR, I'd recommend checking the verbiage that I have used and ensuring it aligns with the terminology in umbraco/Umbraco.CMS.Backoffice#2452.
In reviewing these tests, I noticed that variable names themselves also contain references to ContentApp instead of the new terminology, but I've intentionally refrained from updating those to keep the focus of this PR around the help text that that people will read. (Also because I'm not super familiar with the way the acceptance tests might be wired up to traverse elements in the Backoffice submodule. 😅) With that in mind, it might be good for there to be a future PR that refactors the variable names in these tests to match the terminology that users and developers see when building sites and running tests.