Initialize important services before unattended installs #17366
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.02 (9.13 -> 9.11)
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method ConvertBlockEditorPropertiesBase.cs: Handle
- Code Duplication DocumentCacheService.cs
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)
❌ Getting worse: Complex Method
Handle already has high cyclomatic complexity, and now it increases in Lines of Code from 149 to 168. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)
ℹ Getting worse: Constructor Over-Injection
ConvertBlockEditorPropertiesBase increases from 7 to 8 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)
ℹ Getting worse: Constructor Over-Injection
ConvertBlockGridEditorProperties increases from 8 to 9 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)
ℹ Getting worse: Constructor Over-Injection
ConvertBlockGridEditorProperties increases from 7 to 8 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)
ℹ Getting worse: Constructor Over-Injection
ConvertBlockListEditorProperties increases from 8 to 9 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)
ℹ Getting worse: Constructor Over-Injection
ConvertBlockListEditorProperties increases from 7 to 8 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)
ℹ Getting worse: Constructor Over-Injection
ConvertRichTextEditorProperties increases from 8 to 9 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)
ℹ Getting worse: Constructor Over-Injection
ConvertRichTextEditorProperties increases from 7 to 8 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check warning on line 114 in src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.0)
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: GetByIdAsync,GetByKeyAsync. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.