V8: Selecting text in context menu closes the dialog

[stevemegson]

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #4934

Description

on-outside-click can trigger and close a dialog if you mouse down inside the dialog, then drag and mouse up outside the dialog. To avoid that, this PR triggers on-outside-click on the mousedown event.

Testing:

• Open the Culture and Hostnames dialog
• Click and drag from inside the dialog to somewhere outside it, this should not close the dialog
• Click outside the dialog, and the dialog should still close

---

This item has been added to our backlog AB#4336

[kjac]

I have tested all every occurrence of on-outside-click I could find in the codebase, and they all work with this change far as I can tell.

That being said, previous seemingly well functioning changes to on-outside-click have caused a lot of unexpected havoc in the wild, so ... I'm a bit cautious about any changes made to it.

But from a code perspective and my own smoke tests, the change is fine 👍

@nielslyngsoe should weigh in on this as well.

[umbrabot]

Hi there @stevemegson!

Thanks for the contribution here and apologies if it has been a while since you heard from us. We have been in the very fortunate position of having lots of work to do. With this in mind, we are writing to let you know that with the release of the Long Term Support (LTS) version, 8.18, we have now moved into the support phase of Umbraco 8. You can read all about that here but to surmise, we will be keeping Umbraco 8 safe and well by releasing patching for security or regression issues if they arise but no longer will we do that for bug fixes. The same is still true for features, although we stopped merging those some time ago.

We'd love for you to keep contributing and while we are not able to merge this to Umbraco 8, if this is still something you'd like to see in Umbraco 9, please take a look and either create an issue to say so or find an issue that already exists. We'll be happy to give you some input around how you can adjust your pull request to target Umbraco 9. Even better, it might be something that Umbraco 9 already does or has. In which case, enjoy!

Once again, a huge thank you for the time you have spent working with us.

#H5YR
Your friendly Umbraco GitHub bot 🤖 🙂