V7: Selecting text in context menu closes the dialog #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brilliant @stevemegson! This is going to fix sooo many annoyances. The one thing it unfortunately doesn't seem to fix for me is when you drag outside of a dialog and release the mouse button, then it still closes the dialog. But all the other text selection events in many areas are now behaving properly. Great stuff! |
This was referenced May 4, 2020
|
This is absolutely the bain of my life... thanks @stevemegson |
|
Note: I had to revert this commit: 08480d6 It would prevent the dialogs from opening from the RTE, so the embed and insert media buttons would only sort-of work if you handily double clicked them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #4934, #6023
Description
V7 version of PR #6203.
Additionally, stops swipe events triggering from mouse events. This can also trigger unexpected dialog closes, and can make it impossible to select text when mousemove events are intercepted.
Testing: