-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort on y-axis in listview config layouts #8422
Sort on y-axis in listview config layouts #8422
Conversation
…out not to render
Wonderful @bjarnef! Since 8.7.0 has been closed for additional changes, I'll mark this for 8.7.1 - we'll need to cherrypick this one after 8.7.0 release. |
@nul800sebastiaan was this one merged correctly to Since angular element directives/components are custom HTML elements, they can't be self-closing elements like native elements like e.g. At the moment it isn't possible via the backoffice UI to remove custom listview layouts, because the |
@nul800sebastiaan okay, it was merged, but overwritten again when you merged the PR from @BatJan 1cd79d8#diff-c84512d9cc059db603911cd477e1d82e I have submitted a new PR to fix this: #8478 |
Prerequisites
Description
This PR restrict sorting on y-axis and within parent element. I also noticed the remove button no longer was rendered for custom listviews, because of the self-closing
<umb-checkbox ng-if="layout.isSystem === 1" model="layout.selected" />
. Changing this to<umb-checkbox ng-if="layout.isSystem === 1" model="layout.selected"></umb-checkbox>
fixes this issue.Previous it looked like this as the GIF in this PR:
#5405
In both
umb-checkbox
andumb-radiobutton
I noticed the label had child<div>
elements, which isn't valid for<label>
, so changing this to<span>
instead.Finally the "Add layout" button is also removed outside the sortable placeholder, so it isn't part of the sortable area.