Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove button for custom listview layouts isn't rendered #8478

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 25, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Custom angular element directives/components can't be self-closing elements like navtive elements, e.g. <input type="checkbox value="" />:
https://stackoverflow.com/a/25012451/1693918

This was previous fixed in #8422 but overwritten in 1cd79d8#diff-c84512d9cc059db603911cd477e1d82e

Before

image

After

image

@nul800sebastiaan nul800sebastiaan merged commit f10a3ef into umbraco:v8/contrib Jul 27, 2020
@nul800sebastiaan
Copy link
Member

Whoops! I wasn't paying attention when merging Jan's changes, thanks very much @bjarnef! ⭐

@clausjensen
Copy link
Contributor

Merged to 8.7 as well.

@nul800sebastiaan
Copy link
Member

Guessing this is part of commits d00c075 and f25ee0a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants