Fixing publish descendants dialog

[clausjensen]

Description

The publish descendants dialog was broken at some point going from 8.6->8.7.

I've fixed it up, using the label on the toggle directive instead of using a separate label.

Also updated the localized texts to better reflect what is happening here:

• The toggle allows you to include or exclude publishing of items that have a published state.
• The old help text could indicate that items in a published state but with a "draft" on top would not be published if deselected ... they would be - so this is now more clear.

The last fix done here is that the selected value would not be pushed back to the scope which means your selection would never make it back.

---

This item has been added to our backlog AB#7682

[clausjensen]

When merged, should also be cherrypicked for 8.7 as it is a regression.

[bjarnef]

@clausjensen notice angular directives/components can't be void elements (self-closing), so it needs a end-closing </umb-toggle>.

There is a great explanation of it here: https://stackoverflow.com/a/25012451/1693918

Also here is an example of what can happen when a component/directive is self-closed. Of course native HTML5 elements can still be self-closed like <img />, <br /> etc.
#8478

Here is a PR updating this for <umb-checkbox> and <umb-radiobutton>:
#8547

and this for <umb-toggle> #8605
However if merging this PR and including end-closing </umb-toggle>, then #8605 can just be closed.

[clausjensen]

I've merged your PR as it might be good just for history .. and the whitespace change is fine. Merging this afterwards will overwrite some things in yours which is fine.

[bjarnef]

@clausjensen I have submitted the following PR: #8605

But it seems it was only in this overlay <umb-toggle> was void element. In the PR I removed some whitespace where toggle was used in macros, but since you have localized the text in the controller it should be fine and don't need the <localize> directive in view. It is just missing the end-closing </umb-toggle> instead.

[clausjensen]

I've removed version tag on this as I'm fairly sure this was never actually released in a release.