-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Auto generate alias #2092
Conversation
...ages/core/content-type/workspace/views/design/content-type-design-editor-property.element.ts
Outdated
Show resolved
Hide resolved
I've separated out the Once that's merged in, I'll update this branch with the latest, then it can focus on the auto-generation task. |
# Conflicts: # src/packages/core/components/input-with-alias/input-with-alias.element.ts # src/packages/core/content-type/workspace/views/design/content-type-design-editor-property.element.ts # src/packages/core/property-type/workspace/views/settings/property-workspace-view-settings.element.ts # src/packages/templating/templates/workspace/template-workspace-editor.element.ts
# Conflicts: # src/packages/core/property-type/workspace/views/settings/property-workspace-view-settings.element.ts
as v13 didn't perform that logic.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got around to testing this out, it works better (or more consistent) than v13 did.
Description
Should be working for workspaces and properties.
Re-enables autogeneration of an alias if the alias input become locked while it is empty 🤯🎉
Types of changes
How to test