Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Auto generate alias #2092

Merged
merged 15 commits into from
Aug 20, 2024
Merged

Bugfix: Auto generate alias #2092

merged 15 commits into from
Aug 20, 2024

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Jul 4, 2024

Description

Should be working for workspaces and properties.

Re-enables autogeneration of an alias if the alias input become locked while it is empty 🤯🎉

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

How to test

  • Check if alias autogeneration is enabled for new properties and workspaces.
  • Check if alias autogeneration is disabled for existing properties and workspaces.
  • Check that autogeneration is disabled and stays disabled when the alias has become unlocked.
  • Check if autogeneration can be turned back on by emptying the alias and locking it.

@leekelleher
Copy link
Member

I've separated out the <uui-input-lock> task to its own PR, #2175.

Once that's merged in, I'll update this branch with the latest, then it can focus on the auto-generation task.

# Conflicts:
#	src/packages/core/components/input-with-alias/input-with-alias.element.ts
#	src/packages/core/content-type/workspace/views/design/content-type-design-editor-property.element.ts
#	src/packages/core/property-type/workspace/views/settings/property-workspace-view-settings.element.ts
#	src/packages/templating/templates/workspace/template-workspace-editor.element.ts
@leekelleher leekelleher removed their assignment Aug 14, 2024
# Conflicts:
#	src/packages/core/property-type/workspace/views/settings/property-workspace-view-settings.element.ts
as v13 didn't perform that logic.
@leekelleher leekelleher enabled auto-merge (squash) August 20, 2024 15:58
Copy link

sonarcloud bot commented Aug 20, 2024

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got around to testing this out, it works better (or more consistent) than v13 did.

@leekelleher leekelleher merged commit 70343dc into main Aug 20, 2024
8 checks passed
@leekelleher leekelleher deleted the v14/bugfix/auto-generate-alias branch August 20, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants