Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Use <uui-input-lock> for workspace aliases #2175

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

leekelleher
Copy link
Member

Description

Makes use of the <uui-input-lock> component for workspace name/alias combinations.

Fixes umbraco/Umbraco-CMS#16246.

This PR separates out part of PR #2092, to focus on the <uui-input-lock> component, so to fix the accessibility/tabbing issue (for v14.2.0-RC).

Auto-generating the alias is not part of this PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

How to test?

Test that the padlocked alias UI is accessible in the following areas:

  • Document Type workspace header, name/alias field
  • Media Type workspace header, name/alias field
  • Member Type workspace header, name/alias field
  • User Group workspace header, name/alias field
  • Template workspace header, name/alias field
  • Document Type > Property modal > label/alias field (inside the modal UI)
  • Document Type >Property label/alias field

@leekelleher leekelleher force-pushed the v14/bugfix/uui-input-lock-for-aliases branch from 8a5f710 to 666c5fe Compare August 6, 2024 11:32
@leekelleher leekelleher mentioned this pull request Aug 6, 2024
1 task
@madsrasmussen madsrasmussen changed the base branch from main to release/14.2 August 6, 2024 11:52
@madsrasmussen madsrasmussen self-assigned this Aug 6, 2024
Copy link

sonarcloud bot commented Aug 6, 2024

Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@leekelleher leekelleher merged commit 96ea3d4 into release/14.2 Aug 6, 2024
8 checks passed
@leekelleher leekelleher deleted the v14/bugfix/uui-input-lock-for-aliases branch August 6, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V14-RC3: a11y: cannot tab to alias
2 participants