Bugfix: MNTP min/max validation #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `elementName` constant + linting
- Added `minMessage` and `maxMessage` properties - Added `selection` property; deprecated `items` property - Removed the `switch` from `#onChange`, as the type can be inferred - Set the form control to be the nested picker, (document, media or member)
Sets the form control to be the nested picker `input-content`.
iOvergaard
approved these changes
Jul 5, 2024
|
Looks good to me, but it seems you have some failed tests, @leekelleher |
The "document" package needed to be imported at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wires up the minimum/maximum configuration with MNTP's property-editor validation.
This propagates down to the nested picker components for documents, media and members.
Fixes umbraco/Umbraco-CMS#16442
Also, I found (and fixed) the bug with the
<umb-input-media>component when removing items didn't refresh the UI.Fixes umbraco/Umbraco-CMS#16492
Types of changes