Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: MNTP min/max validation #2094

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Bugfix: MNTP min/max validation #2094

merged 10 commits into from
Jul 8, 2024

Commits on Jul 4, 2024

  1. Housekeeping / boilerplate 

    Adding `elementName` constant + linting
    @leekelleher
    leekelleher committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    ac2a14d View commit details
    Browse the repository at this point in the history

  2. Consistency across the document, media and member pickers

    @leekelleher
    leekelleher committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a07a047 View commit details
    Browse the repository at this point in the history

  3. Bugfix: input-media removing items

    @leekelleher
    leekelleher committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    7bc848e View commit details
    Browse the repository at this point in the history

  4. Refactored input-content to handle min/max validation 

    - Added `minMessage` and `maxMessage` properties
- Added `selection` property; deprecated `items` property
- Removed the `switch` from `#onChange`, as the type can be inferred
- Set the form control to be the nested picker, (document, media or member)
    @leekelleher
    leekelleher committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c573681 View commit details
    Browse the repository at this point in the history

  5. MNTP: Implemented component to inherit from UmbFormControlMixin 

    Sets the form control to be the nested picker `input-content`.
    @leekelleher
    leekelleher committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f607a22 View commit details
    Browse the repository at this point in the history

  6. MNTP: Adds parseInt helper for min/max config values

    @leekelleher
    leekelleher committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    fcc5cc2 View commit details
    Browse the repository at this point in the history

  7. MNTP: Adds min/max validation messages

    @leekelleher
    leekelleher committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    1149adb View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge remote-tracking branch 'origin/main' into v14/bugfix/mntp-min-m… 

    …ax-validation
    @leekelleher
    leekelleher committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ffada2f View commit details
    Browse the repository at this point in the history

  2. Fixed failing test 

    The "document" package needed to be imported at runtime.
    @leekelleher
    leekelleher committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    38af5c7 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into v14/bugfix/mntp-min-m… 

    …ax-validation
    @leekelleher
    leekelleher committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    cd8dce2 View commit details
    Browse the repository at this point in the history