Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umccrise v2.3.1 tool def #388

Merged
merged 2 commits into from
Sep 14, 2023
Merged

umccrise v2.3.1 tool def #388

merged 2 commits into from
Sep 14, 2023

Conversation

pdiakumis
Copy link
Member

Adding umccrise v2.3.1 CWL.
I've added the --1 suffix since I used the --0 suffix in dev with the rc Docker tags (hope that's okay!).

  • Step 1:
cwl-ica create-tool-from-template \
  --tool-name umccrise \
  --tool-version 2.3.1--1 \
  --username "Peter Diakumis"
  • Step 2:
cwl-ica tool-validate \
  --tool-path tools/umccrise/2.3.1--1/umccrise__2.3.1--1.cwl
  • Step 3:
cwl-ica tool-init \
  --tool-path tools/umccrise/2.3.1--1/umccrise__2.3.1--1.cwl --projects "development_workflows,production_workflows"

Extra notes (for my own sake):

There are now new umccrise entries in config/project.yaml under development_workflows and production_workflows, and a new umccrise entry in config/tool.yaml.
I suspect the __GIT_COMMIT_ID__ under the production_workflows gets updated by the PR bot.
The CWL version has also been copied to staging and development from what I can see, probably via Step 3 above.

Copy link
Member

@skanwal skanwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - you're on board with the process ;)

@pdiakumis
Copy link
Member Author

Merging - 2.3.1--1--9344851 added to prod 👍

@pdiakumis pdiakumis merged commit b576cd5 into main Sep 14, 2023
1 check passed
@pdiakumis pdiakumis deleted the umccrise_v2.3.1--1 branch September 14, 2023 00:26
@alexiswl
Copy link
Member

alexiswl commented Sep 17, 2023

Well done Peter! Well documented, and this method is totally fine. In the past I've just used the RC tag on --0 until we've got an actual release and then just replaced the docker tag in the original CWL definition. cwl-ica tool-sync to then overwrite the definition in the development_workflows project. We'd then initialise the tool in the production_workflows project with cwl-ica add-tool-to-project subcommand once we have the proper docker tag.

@victorskl victorskl added the enhancement New feature or request label Sep 18, 2023
@victorskl
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants