Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add manops viewset #488

Merged
merged 4 commits into from
Aug 1, 2022
Merged

add manops viewset #488

merged 4 commits into from
Aug 1, 2022

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Aug 1, 2022 •
edited
Loading

  • Added /manops/rnasum endpoint. Trigger manops lamda from given payload. (Structure)
  • Added workflow service function to find workflow from subject_id. If needed, could make this available through /workflow api by moving it to the manager in /data_portal/models/
  • Added manops lambda name as environment variable.

@williamputraintan williamputraintan self-assigned this Aug 1, 2022
@williamputraintan williamputraintan linked an issue Aug 1, 2022 that may be closed by this pull request
Add REST backend support generate RNAsum report #481
Closed
@victorskl victorskl added the feature New feature label Aug 1, 2022
@victorskl victorskl added this to the Release 1.1.0 milestone Aug 1, 2022
victorskl
victorskl reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just one minor comment on default to dev Lambda. Once that is updated, I will tick approve.

Thank you

data_processors/pipeline/domain/manops.py Show resolved Hide resolved
data_processors/pipeline/services/workflow_srv.py Show resolved Hide resolved
data_processors/pipeline/domain/manops.py Outdated Show resolved Hide resolved
victorskl
victorskl approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arigatō!

@williamputraintan williamputraintan merged commit 0af1184 into dev Aug 1, 2022
@williamputraintan williamputraintan deleted the manops-viewset branch August 1, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

Assignees

@williamputraintan williamputraintan

Labels
feature New feature
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging this pull request may close these issues.

Add REST backend support generate RNAsum report
2 participants
@williamputraintan @victorskl