Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed duplicate tumor normal trigger in concurrent Sequencing #494

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Fixed duplicate tumor normal trigger in concurrent Sequencing #494

merged 1 commit into from
Aug 21, 2022

Conversation

victorskl
Copy link
Member

state machine

  • L1 (N) + L2 (T) = S1
  • L1 in R1, L2 in R2
  • R1 || R2

Fixed #475

@victorskl
Fixed duplicate tumor normal trigger in concurrent Sequencing
ef3fd7c 
state machine
* L1 (N) + L2 (T) = S1
* L1 in R1, L2 in R2
* R1 || R2

Fixed #475
@victorskl victorskl self-assigned this Aug 19, 2022
@victorskl victorskl added the fix label Aug 19, 2022
@victorskl victorskl added this to the Release 1.1.0 milestone Aug 19, 2022
alexiswl
alexiswl approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@alexiswl alexiswl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

reisingerf
reisingerf approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that should do it.

@victorskl victorskl merged commit ef3fd7c into dev Aug 21, 2022
@victorskl victorskl deleted the fix-duplicate-trigger-tn branch August 21, 2022 23:55
@victorskl
Copy link
Member Author

Fix T/N pairing logic to filter out failed runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reisingerf reisingerf reisingerf approved these changes

@alexiswl alexiswl alexiswl approved these changes

Assignees

@victorskl victorskl

Labels
fix
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging this pull request may close these issues.

Fix duplicate trigger for tumor normal samples in back-to-back Runs
3 participants
@victorskl @alexiswl @reisingerf