Fixed Supported ctTSO LabMetadata sample Type Assay combo

[victorskl]

Fixed #508

[alexiswl]

Great work!

[reisingerf]

This will exclude a specific type/assay combination, but the GH issue mentions to exclude all but the known/supported ones?

Why the "If UNSUPPORTED then fail" instead of "if not SUPPORTED then fail"?

Sorry, I may be missing some context here.

[victorskl]

Eh. El. Ok. Think, I got wut you mean.

You mean other samples type and assay combo? I would not consider those yet. That would be pretty broad meta evaluation that might need done elsewhere... I think. May be, at SampleSheet Checker?

I think, I might write the GH issue description a bit vague. My aim is being specific and, fail-safe switch here. Such that this ctTSO annotation combo is well-known and, the most hotspot failure/confusion point. So want to eliminate that.

[reisingerf]

I know and I agree that this will eliminate this known issue case.

All I am saying is: are we keeping the door open for other cases where we could easily close it?
Just saying that looking at the past, the issue was usually not in being too restrictive, but in being too permissive/inclusive.

In this case here, I don't know.
What's your opinion @alexiswl ?

[victorskl]

All I am saying is: are we keeping the door open for other cases where we could easily close it?

Sure. Happy to close as much as possible, of course. Think, we need to discuss these other cases... yes.

Just saying that looking at the past, the issue was usually not in being too restrictive, but in being too permissive/inclusive.

That's correct. It was and, is still permissive!

[reisingerf]

For the current case it looks OK.
(don't what to stall over improvements)

[victorskl]

(Ok, updated GH issue tickie to reflect specific to ctTSO case.)

Baby step, Flo! Baby step. 👶 We will get there, sure. 😉 And... towards OrcaBus! 🐳

[alexiswl]

I know and I agree that this will eliminate this known issue case.

All I am saying is: are we keeping the door open for other cases where we could easily close it? Just saying that looking at the past, the issue was usually not in being too restrictive, but in being too permissive/inclusive.

In this case here, I don't know. What's your opinion @alexiswl ?

Yeah I think allowlist is probably a better way to control than a blocklist. But probably need to think about this further.