Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Portal GDS downloader through PreSigned URLs #520

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Added Portal GDS downloader through PreSigned URLs #520

merged 2 commits into from
Oct 24, 2022

Conversation

victorskl
Copy link
Member

  • Tailored towards HPC Gadi, Spartan
  • Preserved file name using curl -o flag or adjust to desire
  • Verbose steps with minimal basic commands & bash script

@victorskl
Added Portal GDS downloader through PreSigned URLs
4a5fbbb 
* Tailored towards HPC Gadi, Spartan
* Preserved file name using curl -o flag or adjust to desire
* Verbose steps with minimal basic commands & bash script
@victorskl victorskl requested a review from skanwal October 23, 2022 22:29
@victorskl victorskl self-assigned this Oct 23, 2022
@victorskl victorskl added the documentation Improvements or additions to documentation label Oct 23, 2022
@victorskl victorskl added this to the Release 2.0 milestone Oct 23, 2022
skanwal
skanwal requested changes Oct 24, 2022
View reviewed changes
Copy link
Member

@skanwal skanwal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @victorskl.

Just a single comment from my side, otherwise it LGTM and works well.

victorskl
victorskl commented Oct 24, 2022
View reviewed changes
Copy link
Member Author

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Can't seem to find comment pointer. Would you mind point it again, please. @skanwal

skanwal
skanwal requested changes Oct 24, 2022
View reviewed changes
docs/examples/gds_dl_gen.sh Outdated Show resolved Hide resolved
@victorskl victorskl requested a review from skanwal October 24, 2022 06:25
skanwal
skanwal approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@skanwal skanwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@victorskl victorskl merged commit e1bb0db into dev Oct 24, 2022
@victorskl victorskl deleted the portal-gds-downloader branch October 24, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skanwal skanwal skanwal approved these changes

Assignees

@victorskl victorskl

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Release 2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@victorskl @skanwal