Fixed unit test on Holmes Somalier service discovery #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Let Mockito to intercept Holmes pipeline discovery and make it found for unit test case. * Effectively this reduces build time unit test guarding on fingerprint service discovery. Hence, making it optional SOA dependency on Portal. * It will raise graceful Runtime error "Could not find the fingerprint services" where applicable.
andrewpatto
approved these changes
Nov 8, 2022
|
Is good not having this as a hard service dependency.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it found for unit test case.
service discovery. Hence, making it optional SOA dependency on Portal.
where applicable.