Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/fastq API Additional filters #554

Merged
merged 4 commits into from
Feb 21, 2023
Merged

/fastq API Additional filters #554

merged 4 commits into from
Feb 21, 2023

Conversation

williamputraintan
Copy link
Member

  • Allow fastq list to be filtered based on subjectId , workflow, and phenotype.

Link PR: umccr/data-portal-client#231

@williamputraintan williamputraintan added this to the Release 2.1 milestone Feb 21, 2023
@williamputraintan williamputraintan self-assigned this Feb 21, 2023
@williamputraintan williamputraintan mentioned this pull request Feb 21, 2023
Merged
victorskl
victorskl approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment to attend. Otherwise LGTM!

data_portal/models/fastqlistrow.py Outdated Show resolved Hide resolved
data_portal/models/fastqlistrow.py Outdated Show resolved Hide resolved
data_portal/models/fastqlistrow.py Outdated Show resolved Hide resolved
data_portal/models/tests/test_fastqlistrow.py Show resolved Hide resolved
victorskl
victorskl reviewed Feb 21, 2023
View reviewed changes
data_portal/models/fastqlistrow.py Outdated Show resolved Hide resolved
data_portal/models/fastqlistrow.py Outdated Show resolved Hide resolved
data_portal/models/fastqlistrow.py Outdated Show resolved Hide resolved
@victorskl
Copy link
Member

Thanks for fixes. Good to go!

@williamputraintan williamputraintan merged commit b00dc69 into dev Feb 21, 2023
@williamputraintan williamputraintan deleted the fastq-subject-filter branch February 21, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

Assignees

@williamputraintan williamputraintan

Labels
change request
Projects
None yet
Milestone
Release 2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@williamputraintan @victorskl