Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Content-Disposition as header in GDS presign #556

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Accept Content-Disposition as header in GDS presign #556

merged 2 commits into from
Feb 22, 2023

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Feb 22, 2023 •
edited
Loading

Accept Content-Disposition as header to determine presigned_url_mode for GDS file.

Fix #142

To be merged after umccr/libica#89

@williamputraintan williamputraintan added the feature New feature label Feb 22, 2023
@williamputraintan williamputraintan added this to the Release 2.1 milestone Feb 22, 2023
@williamputraintan williamputraintan self-assigned this Feb 22, 2023
victorskl
victorskl approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you also bump to libica-2.2.0rc1 before merge, please?

@williamputraintan williamputraintan merged commit 7d489e7 into dev Feb 22, 2023
@williamputraintan williamputraintan deleted the gds-content-disposition branch February 22, 2023 22:09
This was referenced Feb 23, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

Assignees

@williamputraintan williamputraintan

Labels
feature New feature
Projects
None yet
Milestone
Release 2.1
Development

Successfully merging this pull request may close these issues.

Consider content disposition attachment for presigned download link
2 participants
@williamputraintan @victorskl