Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workDirectory to primary data helper #565

Merged

Conversation

alexiswl
Copy link
Member

Adds workDirectory to engineParameters for BCLConvert runs. This prevents a new gds volume being created every time a new BCLConvert workflow run is spawned.

Resolves #564

@alexiswl alexiswl added the feature New feature label Feb 27, 2023
@alexiswl alexiswl added this to the Release 2.1 milestone Feb 27, 2023
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM.

@victorskl
Copy link
Member

Merging...

@victorskl victorskl merged commit e6a589e into dev Feb 28, 2023
@victorskl victorskl deleted the enhancement/add-workdir-to-bclconvert-engine-parameters branch February 28, 2023 21:00
@victorskl
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BCLConvert run should specify a workDirectory in engineParameters
2 participants