Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Add support for filtering out metadata for libraries not sequenced yet #571

Merged
merged 2 commits into from
Mar 3, 2023
Merged

DRAFT: Add support for filtering out metadata for libraries not sequenced yet #571

merged 2 commits into from
Mar 3, 2023

Conversation

reisingerf
Copy link
Member

Add remove_not_sequenced method to LabMetadataManager
Add simple model tests for get_by_keyword and get_by_keyword_in

@reisingerf
Add support for filtering out metadata for libraries not sequenced yet
e3230eb 
Add `remove_not_sequenced` method to LabMetadataManager
Add simple model tests for `get_by_keyword` and `get_by_keyword_in`
@reisingerf reisingerf requested a review from victorskl March 2, 2023 06:59
@reisingerf
Copy link
Member Author

@victorskl that's what I got to so far.
I think the view only uses the get_by_keyword method, so should be covered.

Not sure about performance in real situations. And there is the question of the build in get method, which we'd probably have to overwrite if it should support the unsequenced filtering...

@victorskl victorskl added this to the Release 2.1 milestone Mar 2, 2023
@victorskl victorskl linked an issue Mar 2, 2023 that may be closed by this pull request
Find a way to deal with DNS library from LabMetadata #548
Closed
@victorskl victorskl added the fix label Mar 2, 2023
@victorskl
Copy link
Member

Cool Flo; I will review this tomorrow.

victorskl
victorskl approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Flo! Minor comment to attend.

I follow up user test and SQL cost in local. All good. Please see in thread.
https://umccr.slack.com/archives/CP356DDCH/p1677557597056759

data_portal/models/tests/test_labmetadata.py Outdated Show resolved Hide resolved
data_portal/models/tests/test_labmetadata.py Outdated Show resolved Hide resolved
data_portal/models/labmetadata.py Show resolved Hide resolved
@reisingerf
Copy link
Member Author

@victorskl If you are happy I'll merge in a bit.
(noticed the thread and SQL cost comparison, nice one! And less than I expected)

@victorskl
Copy link
Member

/gg 👍

@reisingerf reisingerf merged commit 344a793 into dev Mar 3, 2023
@reisingerf reisingerf deleted the issue_548 branch March 3, 2023 00:29
@scwatts scwatts mentioned this pull request Mar 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

Assignees

@reisingerf reisingerf

Labels
fix
Projects
None yet
Milestone
Release 2.1
Development

Successfully merging this pull request may close these issues.

Find a way to deal with DNS library from LabMetadata
2 participants
@reisingerf @victorskl