Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tumor normal and RNAsum to use sequenced only library #574

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

victorskl
Copy link
Member

  • Improved metadata lookup for WGS and WTS
  • Added more test cases

Related #548

* Improved metadata lookup for WGS and WTS
* Added more test cases

Related #548
@victorskl victorskl self-assigned this Mar 8, 2023
@victorskl victorskl requested a review from reisingerf March 8, 2023 23:39
@victorskl victorskl added bug Something isn't working fix labels Mar 8, 2023
@victorskl victorskl added this to the Release 2.1 milestone Mar 8, 2023
@reisingerf
Copy link
Member

Hm, why move the retrieval/query logic into the metadata service?
It is quite specific to the respective service and I would have thought should be/stay in their control/responsibility?

@victorskl
Copy link
Member Author

victorskl commented Mar 9, 2023

Yup. More for unit test-able purpose.

Business query to organised as box-function. Hopefully reusable (if any). But, yes, mainly for unit test / under radar for logic changes.

For example; RNAsum counterpart, I would not need to touch rnasum_step module (front controller) at all. As it delicates business logic into service layer i.e. "box function call" -- by looking at function name, you can hint roughly what it is doing; instead of more generic function; etc.

@victorskl victorskl merged commit 5373dc6 into dev Mar 9, 2023
@victorskl victorskl deleted the fix-dns-lib-tn-rnasum branch March 9, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants