Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STG] Removed GDS MIME type guess at server side #586

Merged
merged 2 commits into from
May 1, 2023
Merged

[STG] Removed GDS MIME type guess at server side #586

merged 2 commits into from
May 1, 2023

Conversation

victorskl
Copy link
Member

Testing in Dev looking good. Promoting the patch fix to Staging.

* Improved implementation on GDS content type and disposition
  as guessing mime at server side introduce side effect than usefulness
  See umccr/data-portal-client#257

* Allowed Client to override GDS PreSigning by payload headers with
  Content-Disposition
  Content-Type
* Both headers must present to activate the presign override method
  Else, use underlay content server auto content negotiation protocol
Removed GDS MIME type guess at server side
@victorskl victorskl self-assigned this Apr 28, 2023
@victorskl victorskl added this to the Release 2.1 milestone Apr 28, 2023
@victorskl victorskl changed the title Release 2.1.1rc1 Removed GDS MIME type guess at server side Apr 28, 2023
@victorskl victorskl changed the title Removed GDS MIME type guess at server side [STG] Removed GDS MIME type guess at server side Apr 28, 2023
@victorskl victorskl added bug Something isn't working fix labels Apr 28, 2023
@victorskl
Copy link
Member Author

Merging...

@victorskl victorskl merged commit dff4e6c into stg May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants