Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star Alignment Automation #616

Merged
merged 8 commits into from
Sep 6, 2023
Merged

Star Alignment Automation #616

merged 8 commits into from
Sep 6, 2023

Conversation

reisingerf
Copy link
Member

No description provided.

@victorskl victorskl changed the title Start alignment automation Star Alignment Automation Sep 6, 2023
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good most of it. Some minor comments to attend.

data_processors/pipeline/lambdas/orchestrator.py Outdated Show resolved Hide resolved
data_processors/pipeline/lambdas/orchestrator.py Outdated Show resolved Hide resolved
data_processors/pipeline/lambdas/star_alignment.py Outdated Show resolved Hide resolved
# TODO: need to find sensible data for those. Could be blank to start with and updated once we receive workflow events?
WFL_ID = "N/A"
WFV_ID = "N/A"
WF_VERSION = "N/A"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With, now, new refactored Workflow constraint made, they become nullable. So, perhaps, leave these 3 out all together..? I will follow up on workflow update side, during even handling.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the workflow name?
Did we decide to leave it to the "client" or control it from the orchestration?
(naming conventions are not needed here, but may be easier to enforce from the portal side)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For first cut, let us leave it to client, Flo. i.e NF stack job submission Lambda i.e. "facade". After the first spin, we shall regroup and discuss. So, we will go with the convention use there - which is not far too off, IMO...

I am kind of thinking - making direct interface to Batch job submission from Portal, instead of "facade" - which gives us/Portal more control (and, scwatt doesn't need to field any change requests to "facade"). Potentially reduce, sort of, double handling...

data_processors/pipeline/lambdas/star_alignment.py Outdated Show resolved Hide resolved
@victorskl victorskl added the feature New feature label Sep 6, 2023
@victorskl victorskl added this to the Release 2.2 milestone Sep 6, 2023
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great..! Good to merge.

@victorskl
Copy link
Member

@reisingerf reisingerf merged commit dda4531 into dev Sep 6, 2023
1 check passed
@reisingerf reisingerf deleted the start-alignment-automation branch September 6, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants