Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented SASH automation #630

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Implemented SASH automation #630

merged 4 commits into from
Oct 12, 2023

Conversation

victorskl
Copy link
Member

  • Added sash_step 👯 module hook to orchestrator
  • Improved look up for oncoanalyser output directory to liborca 🐳
  • Removed duplicate service layer method for workflow by portal_run_id
  • Refactored portal_run_id parsing from path element to liborca
  • Refactored TestConstant portal_run_id(s) stub
  • Improved related unit tests

co-co: @reisingerf

reisingerf and others added 4 commits October 11, 2023 11:54
* Added sash_step module hook to orchestrator
* Improved look up for oncoanalyser output directory to liborca
* Removed duplicate service layer method for workflow by portal_run_id
* Refactored portal_run_id parsing from path element to liborca
* Refactored TestConstant portal_run_id(s) stub
* Improved related unit tests
@victorskl victorskl added the feature New feature label Oct 11, 2023
@victorskl victorskl added this to the Release 2.2 milestone Oct 11, 2023
@victorskl
Copy link
Member Author

@victorskl
Copy link
Member Author

@scwatts FYI

Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
All tests passing.
(after I updated my dev env ;-) )

@victorskl victorskl merged commit 4a35b10 into dev Oct 12, 2023
1 check passed
@victorskl victorskl deleted the sash-automation branch October 12, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants