-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved SQS Lambda handler partial batch responses - ReportBatchItemFailures #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Failures * This feature allows FIFO queue's Lambda trigger to allow partially process of messages in a batch and, still keep exception-raised events in the queue. Essentially, e.g. total 10 messages; 6 process success and 4 exception raised then 6 will clear away from Q; but leave 4 in the Q. Instead of retrying the whole batch. See doc * https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html#services-sqs-batchfailurereporting * https://repost.aws/knowledge-center/lambda-sqs-report-batch-item-failures co-co: @reisingerf
* Prohibit init DRAGEN_WGTS_QC from SecondaryAnalysisHelper constructor * Use WGTS label as aggregated QC batch notification * Improved unit tests and exception handling
reisingerf
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add minor comments, but looks good!
Improved QC implementation and reinforced unit testing
Merging... |
victorskl
added a commit
that referenced
this pull request
Oct 17, 2023
* If SQS handler is configured with `ReportBatchItemFailures` then it has to return in proper Lambda response format such as dict or list. Otherwise, it gets treated as Lambda failure and put into DLQ. Read the doc "Success and failure conditions" clause: https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html#services-sqs-batchfailurereporting * Related #632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of messages in a batch and, still keep exception-raised events in the queue.
Essentially, e.g. total 10 messages; 6 process success and 4 exception raised
then 6 will clear away from Q; but leave 4 in the Q. Instead of retrying the
whole batch.
See doc
co-co: @reisingerf