Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved SQS Lambda handler partial batch responses - ReportBatchItemFailures #632

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

victorskl
Copy link
Member

  • This feature allows FIFO queue's Lambda trigger to allow partially process
    of messages in a batch and, still keep exception-raised events in the queue.
    Essentially, e.g. total 10 messages; 6 process success and 4 exception raised
    then 6 will clear away from Q; but leave 4 in the Q. Instead of retrying the
    whole batch.

See doc

co-co: @reisingerf

…Failures

* This feature allows FIFO queue's Lambda trigger to allow partially process
  of messages in a batch and, still keep exception-raised events in the queue.
  Essentially, e.g. total 10 messages; 6 process success and 4 exception raised
  then 6 will clear away from Q; but leave 4 in the Q. Instead of retrying the
  whole batch.

See doc
* https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html#services-sqs-batchfailurereporting
* https://repost.aws/knowledge-center/lambda-sqs-report-batch-item-failures

co-co: @reisingerf
@victorskl victorskl requested a review from reisingerf October 16, 2023 09:07
@victorskl victorskl self-assigned this Oct 16, 2023
@victorskl victorskl added the fix label Oct 16, 2023
@victorskl victorskl added this to the Release 2.2 milestone Oct 16, 2023
* Prohibit init DRAGEN_WGTS_QC from SecondaryAnalysisHelper constructor
* Use WGTS label as aggregated QC batch notification
* Improved unit tests and exception handling
Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add minor comments, but looks good!

@victorskl
Copy link
Member Author

@victorskl
Copy link
Member Author

Merging...

@victorskl victorskl merged commit 0402072 into dev Oct 17, 2023
@victorskl victorskl deleted the improve-sqs-handler-exception branch October 17, 2023 00:45
victorskl added a commit that referenced this pull request Oct 17, 2023
* If SQS handler is configured with `ReportBatchItemFailures` then it
  has to return in proper Lambda response format such as dict or list.
  Otherwise, it gets treated as Lambda failure and put into DLQ.

  Read the doc "Success and failure conditions" clause:
  https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html#services-sqs-batchfailurereporting

* Related #632
victorskl added a commit that referenced this pull request Oct 18, 2023
* It is observed that while ReportBatchItemFailures fit well
  in FIFO queue with control messaging condition, it is
  a bit counterproductive in Standard queue situation.
  We shall observe more and tune as it goes. Disable for now.
* Related #632 #634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants