Rollback SQS Standard queue event router handler behaviour #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For Standard queue, we would not need to leverage `ReportBatchItemFailures` as exception failure error handling is covered by DLQ. Furthermore, Standard queue are processed in high-throughput manner, i.e. no particular batching control mechanism necessary. Unordered and duplicates are all fine. Underlie application and database will take care of it. * Process simple and fast. If error, keep messages in DLQ. Rolling back to this previous behaviour. * The `ReportBatchItemFailures` is still desirable in all that of FIFO queues.
reisingerf
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReportBatchItemFailuresas exception failure error handling is covered by DLQ. Furthermore,
Standard queue are processed in high-throughput manner, i.e. no particular
batching control mechanism necessary. Unordered and duplicates are all fine.
Underlie application and database will take care of it.
this previous behaviour.
ReportBatchItemFailuresis still desirable in all that of FIFO queues.