Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RNAsum orchestration #674

Merged
merged 4 commits into from
May 27, 2024
Merged

Update RNAsum orchestration #674

merged 4 commits into from
May 27, 2024

Conversation

skanwal
Copy link
Member

@skanwal skanwal commented May 23, 2024

Fixes #672

Noticed we also have data_processors/pipeline/orchestration/tests/test_rnasum_step.py - Not sure if this is being used as there are keys that do not match the current prod workflow.

@skanwal skanwal requested a review from victorskl May 23, 2024 02:37
@skanwal skanwal self-assigned this May 23, 2024
@victorskl
Copy link
Member

.. will review today.

I can follow up on test harness, no worries, Sehrish.

@victorskl
Copy link
Member

Reviewing...

@victorskl victorskl added this to the Release 2.2.2 milestone May 25, 2024
@victorskl
Copy link
Member

So far so good. Verifying on test cases, locally; will complete the PR tick soon.

…ases

Improved RNAsum v1 input keys test cases
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pls merge when you are ready, Sehrish. Once merged, CICD will carry out.

@skanwal skanwal merged commit fc12249 into dev May 27, 2024
1 check passed
@skanwal skanwal deleted the rnasum_inputs_update branch May 27, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RNAsum lambda and orchestration step payload to reflect RNAsum-1.0.0 release
2 participants