Remove srcDoc from <iframe/>
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just quick note, I will review soon; after closing current hot-fix #257 update to PROD. It seems this is minor; so we shall target it to next release, roughly. |
Can we make this as the next hot-fix too? I am categorising this as a bug since it is not supposed to happen, and it broke the preview functionality. |
Ah. Ok, let push it through then. |
victorskl
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out using
srcDocfrom<iframe/>need somehow isolation (based from quick googling), as with current implementation clicking a link from the html previewer will redirect to the parent link. Reproducible by clicking a link from the HTML previewer (say from amultiqc.html) instgorprod.Since umccr/data-portal-apis#581 has been done, will reimplement this to the original solution.