Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove s3-server and dependencies #150

Merged
merged 11 commits into from
Feb 6, 2023
Merged

Remove s3-server and dependencies #150

merged 11 commits into from
Feb 6, 2023

Commits on Jan 31, 2023

  1. Cherry-pick from remove-s3-server branch

    @brainstorm
    brainstorm committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    13e7ab4 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Why are tests passing locally?? :thinking_face: /cc @mmalenic

    @brainstorm
    brainstorm committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7c45b1f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Apply suggestions from @mmalenic on PR review

    @brainstorm
    brainstorm committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    0c7af54 View commit details
    Browse the repository at this point in the history

  2. Bump up s3s-* crates as suggested in #131 (comment)

    @brainstorm
    brainstorm committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    a851a03 View commit details
    Browse the repository at this point in the history

  3. test(search): fix tests related to improperly formatted folder in U… 

    …RLs for S3 mock filesystem
    @mmalenic
    mmalenic committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    7e3feb8 View commit details
    Browse the repository at this point in the history

  4. fix(search): check that a key exists before formatting a URL, ensurin… 

    …g that pre-signed URLs are not generated for non-existent keys
    @mmalenic
    mmalenic committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    2b10b77 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. fix(search): use KeyNotFound error when a key is not found

    @mmalenic
    mmalenic committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    b5b4284 View commit details
    Browse the repository at this point in the history

  2. fix(search): use KeyNotFound for head and get object in AwsS3Storage

    @mmalenic
    mmalenic committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    313fe2c View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. test(search): add set of tests targeting non-existent keys

    @mmalenic
    mmalenic committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    f16a1e7 View commit details
    Browse the repository at this point in the history

  2. build: remove unused dependencies

    @mmalenic
    mmalenic committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    492e20e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/umccr/htsget-rs into s3-ser… 

    …ver-to-s3s

# Conflicts:
#	Cargo.lock
#	htsget-lambda/Cargo.toml
    @mmalenic
    mmalenic committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    01ebf6b View commit details
    Browse the repository at this point in the history