-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update deployment README #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could potentially automate this by simulating 'enter' presses to install zig, but I don't think it's a good idea without user input.
An easier way would be to just pipe to which yes
... while I see your point, this only runs on our CI so there's no much harm on piping yes if we have it under control? This change is a revert to previous RustFunction construct if I understand correctly? I recall that the newer one had some significant speed benefits for our CI too?
This is changing it to the newer one, if you mean the The other one (i.e, the one being replaced in this in this PR) works too, but I think this one is slightly more configurable from a command exec point of view. They should both be the same speed - there was some other issues in orcabus with multiple compilations of the same package which I don't think are happening here anyway. |
Ah, okok, sorry, got them mixed, I thought you were reverting here, all good then, merge! |
Sure, thanks. I'll still try piping |
I'm having trouble getting |
Carry on Marko, getting rid of |
Closes #242
It turns out zig is still required, even though
cargo-lambda
prompts to install it, because theRustFunction
construct doesn't support interactivity. Could potentially automate this by simulating 'enter' presses to install zig, but I don't think it's a good idea without user input.Changes
package.json
dependencies, including removing@aws-cdk/aws-apigatewayv2-alpha
as it's no longer alpha.