Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: htsget-lambda and misc deployment changes #260

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Sep 6, 2024

Closes #258

Changes

  • Use the htsget-axum router for htsget-lambda, avoiding the need for most of the htsget-lambda library code.
  • Update tests to include testing some more error conditions.
  • Fix the Dockerfile.dockerignore and use htsget-axum in the Dockerfile.
  • Update the deployment to allow creating stateful buckets which are populated with the data in the data directory.
    • The docs are updated to clarify the difference between s3BucketResources and the new createS3Buckets.

@mmalenic mmalenic self-assigned this Sep 6, 2024
@mmalenic mmalenic added the refactor changes related to code refactoring label Sep 6, 2024
deploy/lib/htsget-lambda-stack.ts Show resolved Hide resolved
deploy/examples/minio/README.md Outdated Show resolved Hide resolved
@mmalenic
Copy link
Member Author

mmalenic commented Sep 6, 2024

Updates

  • Deployment now has a dedicated example_deploy.toml, with options to create a bucket and copy test data.
    • The deployment should work out of the box, and is public by default.
    • Add warnings in README.md and printed log message about the public deployment.

The only umccr-specific thing left to remove is the hosted zone domain name. I can't think of a way to get rid of this other than just not using a hosted zone, and instead using the ApiGW default endpoint URL.

@mmalenic mmalenic added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit c0e0926 Sep 6, 2024
5 checks passed
@brainstorm brainstorm deleted the refactor/lambda-axum branch September 6, 2024 09:28
@brainstorm brainstorm mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor changes related to code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document why default buckets and example files are not pushed as part of deploy process
2 participants