Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build script #1

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Update build script #1

merged 5 commits into from
Mar 16, 2022

Conversation

williamputraintan
Copy link
Member

  • Added/Modify build layer script (use make build to build all layers)
  • Added make install
  • Change from aws-sam-cli-beta-cdk to aws-sam-cli. As now supported in SAM cli

andrewpatto
andrewpatto reviewed Mar 11, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
reisingerf
reisingerf reviewed Mar 13, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@williamputraintan
Remove version and AWS_PROFILE
a31e46b
@williamputraintan
Change Image lambda layer image
8ae740e 
From `lambci/lambda:build-python3.8` to `public.ecr.aws/sam/build-python3.8`
victorskl
victorskl approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Let push it through for now. We will probably go rounds of iteration on this. Of course.

@williamputraintan williamputraintan merged commit 02c3eec into main Mar 16, 2022
@williamputraintan williamputraintan deleted the update-build-script branch March 16, 2022 22:30
@victorskl victorskl added this to the Release 0.1.0 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reisingerf reisingerf reisingerf left review comments

@andrewpatto andrewpatto andrewpatto left review comments

@victorskl victorskl victorskl approved these changes

Assignees

@williamputraintan williamputraintan

Labels
devops
Projects
None yet
Milestone
Release 0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@williamputraintan @andrewpatto @victorskl @reisingerf