Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filemanager): deserialize event bridge messages #121

Merged
merged 3 commits into from
Feb 26, 2024
Merged

fix(filemanager): deserialize event bridge messages #121

merged 3 commits into from
Feb 26, 2024

Conversation

mmalenic
Copy link
Member

Closes #119

Changes

  • Allow deserializing EventBridge messages as well as SQS messages.
  • Add deserialization tests.
  • Simplify From and TryFrom trait implementations.

@mmalenic mmalenic self-assigned this Feb 26, 2024
@mmalenic mmalenic added the fix label Feb 26, 2024
brainstorm
brainstorm approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice serde aliasing/renaming to have both event types (SQS and EventBridge) into one, kudos!

@brainstorm brainstorm merged commit 919c140 into main Feb 26, 2024
2 checks passed
@brainstorm brainstorm deleted the fix/filemanager-event-serde branch February 26, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees

@mmalenic mmalenic

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filemanager: the structure of S3EventMessage is incorrect for EventBridge events
2 participants
@mmalenic @brainstorm