Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filemanager): correctly deal with null version_id #125

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix(filemanager): correctly deal with null version_id #125

merged 1 commit into from
Feb 27, 2024

Conversation

mmalenic
Copy link
Member

Closes #122

Changes

  • Correctly deals with null values in version_id when ingesting, reordering and detecting duplicates. Got to be careful of null comparisons in postgres 😺.
  • New tests for this case.

@mmalenic mmalenic self-assigned this Feb 27, 2024
@mmalenic mmalenic added fix filemanager an issue relating to the filemanager labels Feb 27, 2024
brainstorm
brainstorm approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, good catch and fix!

@brainstorm brainstorm merged commit 19b9bf1 into main Feb 27, 2024
2 checks passed
@brainstorm brainstorm deleted the fix/sql_version_id branch February 27, 2024 23:39
This was referenced Mar 5, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees

@mmalenic mmalenic

Labels
filemanager an issue relating to the filemanager fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filemanager: SQL queries do not consider null version_id values
2 participants
@mmalenic @brainstorm