Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pipeline): install Rust for unit tests #154

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(pipeline): install Rust for unit tests #154

merged 1 commit into from
Mar 14, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Mar 14, 2024 •
edited
Loading

Fixes #153

Changes

  • Add Rust back to pipeline in order to run unit tests.

Potentially another way around this is to dockerize the unit tests? Although not sure if something like that is necessary.

@mmalenic mmalenic self-assigned this Mar 14, 2024
victorskl
victorskl approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmalenic mmalenic merged commit 187a5b6 into main Mar 14, 2024
2 checks passed
@mmalenic mmalenic deleted the fix/codebuild branch March 14, 2024 06:24
@mmalenic mmalenic mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

@williamputraintan williamputraintan Awaiting requested review from williamputraintan

Assignees

@mmalenic mmalenic

Labels
fix platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: pipeline does not have Rust installed
2 participants
@mmalenic @victorskl