Finalised Token Service fixes and improvement #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
victorskl
commented
Apr 10, 2024
victorskl
commented
- Removed policy sid as advice
- Tuned policy based on Policy Sim
- Tuned cognitor implementation
- Deprecated module helper.py
- Fixed and improved module impl rotate_service_jwt.py
- Fixed and improved module impl rotate_service_user.py
- Improved README.md
* Removed policy sid as advice * Tuned policy based on Policy Sim * Tuned cognitor implementation * Deprecated module helper.py * Fixed and improved module impl rotate_service_jwt.py * Fixed and improved module impl rotate_service_user.py * Improved README.md
reisingerf
approved these changes
Apr 10, 2024
| return ''.join( | ||
| random.SystemRandom().choice(string.ascii_letters + string.digits + '!@#$%&.') for _ in range(length) | ||
| random.SystemRandom().choice(string.ascii_letters + string.digits + '_-!@#%&.') for _ in range(length) |
There was a problem hiding this comment.
Ah, user pool password policy demands at least one special character.... right!
There was a problem hiding this comment.
Yup. We can tune that though. But, let better be some symbols there, Flo.
There was a problem hiding this comment.
Yup, noticed the custom policy option. Agree though, better to stick to the default
|
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.