Serverless MySQL #22
Merged
Serverless MySQL #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
williamputraintan
commented
May 23, 2023
williamputraintan
commented
- Attempt on changing to Serverless MySQL
| export class SecurityGroupConstruct extends Construct { | ||
| constructor(scope: Construct, id: string, vpc: IVpc, props: SecurityGroupProps) { | ||
| constructor(scope: Construct, id: string, vpc: ec2.IVpc, props: SecurityGroupConstructProps) { | ||
| super(scope, id); | ||
|
|
There was a problem hiding this comment.
Just wondering here, if the SG is purposely for lambda, would it be better if this is created right on the stack where lambda will be created (on the OrcaBusStatelessStack before the workflow construct)?
There was a problem hiding this comment.
You are right that there will be another App specific SG down there in Stateless Construct for other inbound/outbound rules need.
However. This SG is special for Lambda to Database within VPC. Because the DB will be placed in Isolated subnet i.e. air-gapped. No direct access from Internet nor external but must be within VPC only.
So need to keep this one at Stateful.
|
Thanks Will for PR. I will review soon, tomorrow arvo, probably. |
victorskl
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.