Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileManager microservice Rust skel #27

Merged
merged 18 commits into from
Jun 15, 2023
Merged

FileManager microservice Rust skel #27

merged 18 commits into from
Jun 15, 2023

Conversation

brainstorm
Copy link
Member

... and initial draft/incomplete definition of filemanager microservice client API.

@brainstorm brainstorm changed the title OpenAPI restructuring FileManager microservice Jun 12, 2023
@brainstorm brainstorm requested a review from mmalenic June 12, 2023 23:55
victorskl
victorskl reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM so far; will review in more once PR is finalised! 👍

@reisingerf
Copy link
Member

Great start, thanks!
(expect stupid noob Rust questions though ;-) )

@brainstorm
@reisingerf, test it out with those instructions, let's see if there …
f192536 
…are quickstart/doc gaps at this point ;)
@brainstorm
FileManager->File rename as suggested by Florian
d49d8ff
@brainstorm
[ci skip] Minor rename fixes
a570ad2
@brainstorm
Restructure openapi folder a bit more to not break docker-compose, ad…
852806c 
…d filemanager initial openapi definition to prism
@brainstorm
Sketch some onboarding docs for rust-api microservices
1070df4
@brainstorm
FileQuery struct might not be required after all? Simplifying...
b77fd6a
@brainstorm
Add sqlx types such as datetime for db types matching
c8a276f
@brainstorm
First barebones DB query from data_portal's GDSFile table. Needs prop…
ffd6520 
…er type matching and discuss FM design a bit more
@brainstorm
Add migrations support, still keeping it ORM-less for now
ca8e669
@brainstorm
Add some Rust tutorial hints for the team
7915148
@brainstorm brainstorm marked this pull request as ready for review June 14, 2023 00:15
@victorskl victorskl added the feature New feature label Jun 15, 2023
@victorskl victorskl added this to the Release 0.1.0 milestone Jun 15, 2023
@victorskl
Copy link
Member

OrcaBus V1: Design and Implement File Manager

victorskl
victorskl approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust skel looks good and LGTM! Happy to merge this ahead first as we would need to base OpenAPI doc arrangement from this PR.

@brainstorm brainstorm changed the title FileManager microservice FileManager microservice skel Jun 15, 2023
@brainstorm brainstorm changed the title FileManager microservice skel FileManager microservice Rust skel Jun 15, 2023
@brainstorm brainstorm merged commit 94d72e7 into main Jun 15, 2023
reisingerf
reisingerf reviewed Jun 16, 2023
View reviewed changes
Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LATM

@brainstorm brainstorm deleted the filemanager branch November 17, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalenic mmalenic mmalenic left review comments

@reisingerf reisingerf reisingerf left review comments

@victorskl victorskl victorskl approved these changes

Assignees

@brainstorm brainstorm

Labels
feature New feature
Projects
None yet
Milestone
Release 0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@brainstorm @reisingerf @victorskl @mmalenic