Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Metadata Manager #35

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Init Metadata Manager #35

merged 6 commits into from
Jul 12, 2023

Conversation

williamputraintan
Copy link
Member

An init migration of the Metadata Model

  • Migrating metadata from data-portal-api to this manager
  • Add timestamp for each record created, and allow to save all history changes at every sync to the Django model
  • Some unit-tests to support the model

@victorskl
Copy link
Member

@victorskl
Copy link
Member

Thanks Will; I will review in tomorrow soon.

Meanwhile, when PR #32 get merged into the main, please rebase it.
Then, it should take care of container image pull rate throttle issue by using GHA action cache. 🤞

Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for first cut. So, go merge it, if any. Squash merge if you can.

Please do check with @reisingerf whether this should now be called LibraryManager or otherwise...

Also. We can revisit/tinkering about whether keep doing truncate & reload or, change-data-capture CDC with differential data loading...

Just pull up note reminder. No blocker. Leave it to you for follow up! 😃

Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A great start!

Minor things to follow up on:
We should rename this from metadata to library as discussed and mentioned by Victor.
The Django config settings were also discussed with Victor and I think we decided to remove the defaults to avoid possible misconfiguration if the env is not explicitly set up.

@williamputraintan williamputraintan merged commit e2e130b into main Jul 12, 2023
@williamputraintan williamputraintan deleted the feat/metadata-manager branch July 12, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants