-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Metadata Manager #35
Conversation
Thanks Will; I will review in tomorrow soon. Meanwhile, when PR #32 get merged into the main, please rebase it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good for first cut. So, go merge it, if any. Squash merge if you can.
Please do check with @reisingerf whether this should now be called LibraryManager or otherwise...
Also. We can revisit/tinkering about whether keep doing truncate & reload or, change-data-capture CDC with differential data loading...
Just pull up note reminder. No blocker. Leave it to you for follow up! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A great start!
Minor things to follow up on:
We should rename this from metadata to library as discussed and mentioned by Victor.
The Django config settings were also discussed with Victor and I think we decided to remove the defaults to avoid possible misconfiguration if the env is not explicitly set up.
An init migration of the Metadata Model