feat: filemanager sea-orm entities #357
Conversation
mmalenic
force-pushed
the
feat/filemanager
branch
from
ea741a7
to
5cb988a
Compare
| let generated = quote!( | ||
| // Auto-generated by the filemanager build script. | ||
| #[path = #path] | ||
| pub mod entities; | ||
| ); |
There was a problem hiding this comment.
This is required to be able to include the module in the filemanager crate using include!(concat!(env!("OUT_DIR"), "/entities.rs")). My IDE is able to pick up these modules okay, AFAIK vscode should work too.
| /// Create an error with caller location to print error information. | ||
| #[track_caller] | ||
| fn from(error_kind: ErrorKind) -> Self { | ||
| let loc = Location::caller(); | ||
|
|
||
| if let Some(path) = workspace_path() { | ||
| if let Ok(source) = read_to_string(path.join(loc.file())) { | ||
| let offset = SourceOffset::from_location( | ||
| source.as_str(), | ||
| loc.line() as usize, | ||
| loc.column() as usize, | ||
| ); | ||
|
|
||
| return Self::new( | ||
| error_kind, | ||
| Some(NamedSource::new(loc.file(), source)), | ||
| Some(offset), | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| Self::new(error_kind, None, None) | ||
| } |
There was a problem hiding this comment.
Using miette for nicer compile/build error printing. #[track_caller] is useful to print line information about where an error occurred, similar to the Rust compiler.
mmalenic
added
filemanager
There was a problem hiding this comment.
If I understand the code correctly, filemanager-build/src/entities.rs generates ... entities.rs that will be include!-d on mod.rs... for easier source code navigation I would prefix with gen_ or similar (i.e gen_entities.rs), otherwise it gets confusing what codegens what (entities.rs codegenerating another entities.rs somewhere else?) :-S
If filemanager-build/src/entities.rs is the generated file, I'd put a header that states that: Autogenerated file, see the other file gen_entities.rs for its source/generation.
|
That's a good call, |
Either way works, just make it clear which generates and which is generated ;) |
Closes #314
Changes
filemanager-buildcrate is used for better code organisation.Leaving this as a draft for now until the phase 1 deployment is complete.