Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(metadata-manager): Schema Change #411

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

williamputraintan
Copy link
Member

  • Added test bucket data for OrcaBus use
  • Some dump/load for MM local deployment
  • Change Subject -> Specimen to one-to-many

Copy link

gitguardian bot commented Jul 12, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
6757493 Triggered Generic Password 9127692 lib/workload/stateless/stacks/metadata-manager/Makefile View secret
6757493 Triggered Generic Password 9127692 lib/workload/stateless/stacks/metadata-manager/Makefile View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@williamputraintan williamputraintan changed the title Feat: Schema Changes Feat(metadata-manager): Schema Changes Jul 12, 2024
@williamputraintan williamputraintan changed the title Feat(metadata-manager): Schema Changes Feat(metadata-manager): Schema Change Jul 12, 2024
@victorskl victorskl linked an issue Jul 12, 2024 that may be closed by this pull request
@victorskl
Copy link
Member

Gotta off for the day soon. I will review it on Monday, Will.

Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamputraintan williamputraintan merged commit ebbbba9 into main Jul 15, 2024
5 checks passed
@williamputraintan williamputraintan deleted the feat/mm-schema-change branch July 15, 2024 04:40
This was linked to issues Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema Model Change Setup SQL Dump/Reload in Local Development Metadata docs
2 participants