Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filemanager): attribute updating API #424

Merged
merged 10 commits into from
Jul 26, 2024

Conversation

mmalenic
Copy link
Member

Closes #423

Changes

  • Adds multiple PATCH routes which allow updating the attributes column for a single s3_object/object, or a collection of records.
    • This uses JSON patch to perform the update by first querying the database for the correct records to update, then applying the patch to the attributes column, and writing the attributes back to the database.
  • Add tests for the new endpoints and update the openapi docs.
  • Return NOT_FOUND for getting/updating single records if the supplied id does not exist.
  • Bump a few dependencies.

To do

This is part of the change that allows attribute linking. In theory, any service can now add whatever attributes they want to a filemanager record. Still to do is implementing a rule system to submit jobs for linking attributes on filemanager records, and allowing attributes to be updated using the EventBus instead of a PATCH request.

@mmalenic mmalenic self-assigned this Jul 26, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager feature New feature labels Jul 26, 2024
@mmalenic
Copy link
Member Author

mmalenic commented Jul 26, 2024

Update

  • Fixed an error when running the local filemanager-api-server due to a missing "env-filter" feature flag on "tracing-subscriber".
  • Added ability to specify current state for the update s3_object attributes endpoint.

@mmalenic mmalenic merged commit ff96456 into main Jul 26, 2024
5 checks passed
@mmalenic mmalenic deleted the feat/filemanager-attribute-link branch July 26, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature filemanager an issue relating to the filemanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filemanager: attribute updating API
2 participants