Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filemanager API wildcards #457

Merged
merged 7 commits into from
Aug 9, 2024
Merged

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Aug 8, 2024

Closes #456

Changes

  • Add wildcard matching to API routes for list/update.
    • Wildcards use '%' for multiple characters and '_' for single characters, which get converted to like queries.
    • case_sensitive can be used to control whether the query is like or ilike.
    • Wildcards are also supported in JSON attributes.
  • Add API guide and design docs.
  • Update tests and OpenAPI definitions.

@mmalenic mmalenic changed the title feat: filemanager API wildcard feat: filemanager API wildcards Aug 8, 2024
@mmalenic mmalenic self-assigned this Aug 8, 2024
@mmalenic mmalenic added feature New feature filemanager an issue relating to the filemanager labels Aug 8, 2024
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for note taking around API and attribute linking.

@mmalenic mmalenic merged commit 71ac639 into main Aug 9, 2024
5 checks passed
@mmalenic mmalenic deleted the feat/filemanager-api-matching branch August 9, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature filemanager an issue relating to the filemanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filemanager: improve API to include wildcard matching
2 participants