Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(filemanager): remove object table #465

Merged
merged 2 commits into from
Aug 12, 2024
Merged

refactor(filemanager): remove object table #465

merged 2 commits into from
Aug 12, 2024

Conversation

mmalenic
Copy link
Member

Closes #464

Changes

  • Remove the object table.
  • Also remove public_id from s3_object as it isn't being used. This can be reintroduced if necessary.
  • Remove some tests as they are more related to custom re-ordering logic using paired_ingest_mode, rather than the default simpler ingestion.
  • Rename routes/functions.

@mmalenic mmalenic self-assigned this Aug 12, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager refactor labels Aug 12, 2024
victorskl
victorskl approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalenic mmalenic merged commit a4b4789 into main Aug 12, 2024
5 checks passed
@mmalenic mmalenic deleted the refactor/api-standardise branch August 12, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

@brainstorm brainstorm Awaiting requested review from brainstorm

Assignees

@mmalenic mmalenic

Labels
filemanager an issue relating to the filemanager refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filemanager: remove object table
2 participants
@mmalenic @victorskl