Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonised API v1 versioning namespace base URL #468

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Harmonised API v1 versioning namespace base URL #468

merged 4 commits into from
Aug 13, 2024

Conversation

victorskl
Copy link
Member

@victorskl victorskl commented Aug 12, 2024 •
edited
Loading

This will harmonise API base URL into:

https://metadata.dev.umccr.org/api/v1/
https://sequence.dev.umccr.org/api/v1/
https://workflow.dev.umccr.org/api/v1/
https://file.dev.umccr.org/api/v1/

@victorskl victorskl self-assigned this Aug 12, 2024
@victorskl
Fixed Workflow Manager API filter by attributes
5d1a2de 
* This reinstate API request query parameter filter by each
  viewsets field attribute including FK linked model fields.
@victorskl
Merge pull request #469 from umccr/fix-workflow-manager-api-attribute…
f240c3a 
…-filter

Fixed Workflow Manager API filter by attributes
@victorskl victorskl marked this pull request as ready for review August 13, 2024 01:13
@victorskl
Copy link
Member Author

Looking into unit test failure

@victorskl
Copy link
Member Author

CI pass. Merging...

@victorskl victorskl merged commit 847ff6d into main Aug 13, 2024
5 checks passed
@victorskl victorskl deleted the harmonise-api-namespace branch August 13, 2024 02:07
@victorskl victorskl mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamputraintan williamputraintan williamputraintan approved these changes

@reisingerf reisingerf reisingerf approved these changes

Assignees

@victorskl victorskl

Labels
change request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorskl @reisingerf @williamputraintan