-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(filemanager): API style #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just minor comments.
|
||
```sh | ||
curl --get -H "Authorization: Bearer $TOKEN" --data-urlencode "key=temp\_data%" \ | ||
"https://file.dev.umccr.org/api/v1/s3_objects?case_sensitive=false" | jq | ||
"https://file.dev.umccr.org/api/v1/s3?case_sensitive=false" | jq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"https://file.dev.umccr.org/api/v1/s3?caseSensitive=false" | jq
@@ -8,4 +8,7 @@ the relevant token: | |||
curl -H "Authorization: Bearer $orcabus_api_token" https://file.<stage>.umccr.org/api/v1/s3_objects/count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl -H "Authorization: Bearer $orcabus_api_token" https://file.<stage>.umccr.org/api/v1/s3/count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Good catch.
Closes #458
Changes
camelCase
.-
and_
.swagger-ui
instead ofswagger_ui
.