Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filemanager): presigned URL access #499

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Aug 19, 2024

Related to #459

Changes

  • Fix presigned URL route so that URLs can be accessed. The fix is two-fold:
    • The API function needs GetObject access to the buckets.
    • Checksum mode should not be used because this creates an additional header x-amz-checksum-mode which is supposed to be present when fetching the presigned URL.
  • Adjust Makefile so that finding a postgres database behaves nicer with the top-level make start-all-service.

@mmalenic mmalenic self-assigned this Aug 19, 2024
@mmalenic mmalenic linked an issue Aug 19, 2024 that may be closed by this pull request
@victorskl victorskl added the fix label Aug 19, 2024
@mmalenic mmalenic added the filemanager an issue relating to the filemanager label Aug 19, 2024
@mmalenic mmalenic merged commit 50f2ba2 into main Aug 19, 2024
5 checks passed
@mmalenic mmalenic deleted the fix/filemanager-presign branch August 19, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filemanager an issue relating to the filemanager fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filemanager: add presigned URL route
3 participants